https://bugzilla.redhat.com/show_bug.cgi?id=1910798 --- Comment #4 from code@xxxxxxxxxxxxxxxxxx --- Thanks, I can confirm that you made all of the requested changes. ---- I see you dropped %pyproject_save_files; no problem with that. A matter of personal choice. ---- The new patch is reasonable, in that it provides an equivalent version requirement; is properly justified with a comment; and does not need to be upstreamed, as it only applies to older versions of pip. However, according to my testing: - Fedora 34 has a new enough pip that it does not need the patch. - Fedora 33 needs the patch. - Fedora 32 has too old a Sphinx (2.2.2) for the package to build anyway. In the spirit of staying close to upstream, I’d like to see the patch conditionally applied, to ensure it is dropped when no longer required. Changing %autosetup -n %{srcname}-%{version} to %setup -q -n %{srcname}-%{version} %if 0%{?fedora} == 33 %patch0 %endif should handle it. ---- Given that you can’t support Fedora 32 due to the Sphinx version, you should drop the %py_provides macro too. --- With those two changes, I will be ready to approve the package. Thanks for your work on this! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
