https://bugzilla.redhat.com/show_bug.cgi?id=1910798 Mohamed El Morabity <pikachu.2014@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(pikachu.2014@gmai | |l.com) | --- Comment #3 from Mohamed El Morabity <pikachu.2014@xxxxxxxxx> --- Thanks for your review. Here is a new version (update to 2020.12.9b21): Spec URL: https://melmorabity.fedorapeople.org/packages/python-furo/python-furo.spec SRPM URL: https://melmorabity.fedorapeople.org/packages/python-furo/python-furo-2020.12.30b24-1.fc33.src.rpm (In reply to code from comment #1) > - Package should BR python3-devel. Fixed > - Apparently bogus Requires on setuptools. Fixed > - Should not use python_provide macro. A legacy from previous guidelines. Now using %py_provides as recommended in https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_the_py_provides_macro (at least for Fedora < 33) > - Do you need the Provides: “%{srcname} = %{version}-%{release}”? It is > permissible, but most Python packages do not do this; is there reason > to believe anyone will be looking to “dnf install furo” instead of > “dnf install python3-furo”? Otherwise, I would strongly encourage removing > this line. You're right, this is not needed for this package obviously. My spec file was based on another with such a Provides, I forgot to remove this line. Fixed -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
