https://bugzilla.redhat.com/show_bug.cgi?id=1910798 --- Comment #5 from code@xxxxxxxxxxxxxxxxxx --- Okay, I really hate to do this, but there is one more thing I didn’t notice before. The PyPI source tarball (which you are using) contains the “compiled”/minified web assets only, and the GitHub source tarball (which you are not using) contains the “sources” (unminified JavaScript, SASS from which the CSS is generated…). My reading of https://docs.fedoraproject.org/en-US/packaging-guidelines/what-can-be-packaged/#_pregenerated_code is that it applies to this case. At a minimum, it would require you to add the GitHub tarball as a second source to get the ”real sources,” e.g. %global tag %(echo %(version) | sed -r 's/([[:digit:]]+)b([[:digit:]]+)$/\1.beta\2/') Source1: https://github.com/pradyunsg/%{srcname}/archive/%{tag}.tar.gz There is another problem, though: beyond the general rules for generated code, https://docs.fedoraproject.org/en-US/packaging-guidelines/JavaScript/#_compilationminification specifically bans shipping pre-compiled or pre-minified JavaScript. (Looking at the GitHub sources also revealed a forked, bundled copy of js-gumshoe, https://github.com/pradyunsg/furo/blob/main/src/furo/assets/scripts/gumshoe-5.1.2-patched.js, which would need a Provides: per https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling.) I am not sure what the right next steps are here. Maybe, as the guidelines suggest, it might be possible to prepare the assets in the RPM build—but it would take a totally separate build pipeline, as the upstream gulpfile isn’t going to be usable in an offline RPM build. It seems challenging. I’ll spend a little time looking at it if I have a chance. Or maybe the FPC would be inclined to grant an exception (https://pagure.io/packaging-committee/issues), although that seems like a long shot. I hope a solution is possible. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
