https://bugzilla.redhat.com/show_bug.cgi?id=1910504 --- Comment #2 from Timothée Floure <timothee.floure@xxxxxxxxxx> --- Spec URL: https://git.sr.ht/~fnux/hikari-rpm/blob/4038784238db53f19d5f40753b918ad1e07165fa/libucl/libucl.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/fnux/hikari/fedora-rawhide-x86_64/01849059-libucl/libucl-0.8.1-3.fc34.src.rpm Thanks for the tips, Micheal! I made the devel subpackage require arch-dependent base package, and run the test suite in the check section. I don't think the 'packaging static library' guidelines are relevant here, since the package ships a dynamically linked library...? > Since /usr/include is a standard search path, explicitly adding it via -I can troublesome > in projects that want to customize the include directories. Regarding the above topic: I suppose I can remove `Cflags: -I${includedir}/` from /usr/lib64/pkgconfig/libucl.pc, althought such a thing seems fairly common (if not present everywhere) from what I can see on my system. There is, as far as I know, no guideline on this: I think I would let the upstream file untouched, but am not strongly opinionated. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
