[Bug 1910504] Review Request: libucl - Universal configuration library parser

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1910504



--- Comment #3 from Michael Schwendt <bugs.michael@xxxxxxx> ---
> %{_libdir}/libucl.a

That _is_ a static library.


> %{_libdir}/libucl.la

That is a socalled libtool archive, which is also covered by the linked
packaging guidelines, because .la files are an extra source of trouble (not
limited to introducing a complex and growing set of inter-library dependencies
at build-time).


> %check

It is worth noting that the %check section is executed _after_ %install, which
also makes it possible to run tests on files installed into %buildroot, so
within the spec file, usually %check is placed after %install as to be
explicit.


> `Cflags: -I${includedir}/` 

Well, you could remove the trailing slash character, and pkg-config will be
smart enough to recognize the standard header path.

$ pkg-config --cflags libucl
-I/usr/include/ 
$ sudo sed -i 's!}/$!}!g' /usr/lib64/pkgconfig/libucl.pc
$ pkg-config --cflags libucl

$


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux