https://bugzilla.redhat.com/show_bug.cgi?id=1878903 --- Comment #6 from Andy Mender <andymenderunix@xxxxxxxxx> --- > I have added javapackages-filesystem. However, java-headless is not good enough. This package uses Java's GUI features, so the dependency has to be on java. This is covered by https://docs.fedoraproject.org/en-US/packaging-guidelines/Java/#_buildrequires_and_requires. Makes sense! > Good catch. The icons are GPLv2, so I have added that license to the License field. I ran a license check against this doc, since the package has multiple licenses: https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses There are some aspects of LGPLv2 vs GPLv2 which make certain scenarios not permissible, but I think in this case it's okay. A follow-up COPR build with latest naga: https://copr.fedorainfracloud.org/coprs/andymenderunix/jmol/build/1690301/ Before I approve, could you have a look at the failed builds on Fedora 32? It seems like it's picking up Java 8 and not 11. Or is the package not compatible with Java < 11 and should only go into Fedora 33+? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
