https://bugzilla.redhat.com/show_bug.cgi?id=1878903 --- Comment #5 from Jerry James <loganjerry@xxxxxxxxx> --- (In reply to Susi Lehtola from comment #3) > The unretiring guideline > https://fedoraproject.org/wiki/Orphaned_package_that_need_new_maintainers > says: "Restore the contents in GIT and prepare a new build and update (if > necessary)" > > which means that the changelog shouldn't be purged, as for any other update. I missed that. Thanks for pointing it out. I have restored the entire changelog. (In reply to Andy Mender from comment #4) > A couple of new versions were recently released, newest being 14.31.8: > https://sourceforge.net/projects/jmol/files/Jmol/Version%2014.31/Jmol%2014. > 31.8/ Upstream seems to release frequently. I'm sure that will make maintaining this package ... interesting. :-) I have updated to version 14.31.8. > The Java Packaging Guidelines mention also that a Requires on > javapackages-filesystem and java-headless should be added as well: > https://docs.fedoraproject.org/en-US/packaging-guidelines/Java/ I have added javapackages-filesystem. However, java-headless is not good enough. This package uses Java's GUI features, so the dependency has to be on java. This is covered by https://docs.fedoraproject.org/en-US/packaging-guidelines/Java/#_buildrequires_and_requires. > If jsmol is an independent package, it needs to provide its own license file > with the %license macro. If it's not independent, it needs to explicitly > Requires the main jmol package: > > Requires: %{name} = %{version}-%{release} I have added the license files to jsmol. > > # Icons from Nuvola are included, but at different sizes than Fedora provides > > Provides: bundled(nuvola-icon-theme) > > Is the license on this icon set compatible with the other licenses? Good catch. The icons are GPLv2, so I have added that license to the License field. New URLs: Spec URL: https://jjames.fedorapeople.org/jmol/jmol.spec SRPM URL: https://jjames.fedorapeople.org/jmol/jmol-14.31.8-1.fc34.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
