[Bug 1878903] Review Request: jmol - Java viewer for chemical structures in 3D

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1878903



--- Comment #7 from Jerry James <loganjerry@xxxxxxxxx> ---
Thank you for the review, Andy.

(In reply to Andy Mender from comment #6)
> Before I approve, could you have a look at the failed builds on Fedora 32?
> It seems like it's picking up Java 8 and not 11. Or is the package not
> compatible with Java < 11 and should only go into Fedora 33+?

I have a comment at the top of the spec file about this.  My intention is to
leave the package alone in <= F32 and only build this version of it in F33+. 
There is a conditional

%if 0%{fedora} <= 32

on line 128 of the spec file from when I tried to get this all to work on F32,
but I think I will remove that before importing.  The problem is that patch0
sets target to 11, which makes JDK 8 unhappy.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux