https://bugzilla.redhat.com/show_bug.cgi?id=1860688 Bug ID: 1860688 Summary: Review Request: epic5 - irc client (currently retired) Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@xxxxxxxxxxxxxxxxx Reporter: p@xxxxxxxxx QA Contact: extras-qa@xxxxxxxxxxxxxxxxx CC: package-review@xxxxxxxxxxxxxxxxxxxxxxx Target Milestone: --- Classification: Fedora Spec URL: https://kobol.org/~p/fedora-rpms/epic5/epic5.spec SRPM URL: https://kobol.org/~p/fedora-rpms/epic5/epic5-2.1.2-1.fc32.src.rpm Description: [ This is my first package and I need a sponsor! ] I would like to bring the epic5 package out of retirement -- it was retired because the former maintainer is MIA, not for any technical or upstream-related reasons. The process outlined in <https://fedoraproject.org/wiki/Orphaned_package_that_need_new_maintainers#Claiming_Ownership_of_a_Retired_Package> states that as this package has been retired for more than 8 weeks it must be reviewed as if it were new. For reference, the former spec file is here: https://src.fedoraproject.org/rpms/epic5/blob/16c66c744345bf4950a60c25e31232f6878f9793/f/epic5.spec I have cleaned up the spec file and made the following changes: - Updated to version 2.1.2 - Removed BuildRoot: and Group: tags, and %clean section per packaging guidelines - Changed Source0 to use .xz file instead of .gz - Added gcc and gdbm-devel to BuildRequires: and reformatted - Improved description - Modify CFLAGS as per warning in INSTALL file (noted with comment) - Change %build and %install sections to be in accordance with packaging guidelines - Removed --with-ssl and --with-ipv6 from %configure as these are already default options - Change --with-wserv to --without-wserv (I have never known anybody to use this). The epic package (epic4) also removes wserv post-build. - Add %license to %files section - Add documentation in %files section that wasn't included in former spec file I have built the package on my local system and confirmed it works, I have also built successfully on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=47871089 Fedora Account System Username: avalon -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx