[Bug 1860688] Review Request: epic5 - irc client (currently retired)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1860688



--- Comment #3 from Andy Mender <andymenderunix@xxxxxxxxx> ---
> Okay - ncurses and openssl worked with pkgconfig() but gdbm didn't so I have left that as -devel.

I tried building from your SPEC file with a little tweak for "pkgconfig(gdbm)"
in Fedora 33 (local x86_64 mock environment), but the -devel package in Fedora
33 doesn't seem to provide a pkgconfig file either.

> I'm not sure where that documentation size has come from:

> [p@athena:~/rpmbuild/BUILDROOT/epic5-2.1.2-1.fc32.x86_64/usr/share/doc/epic5] % du -sh .
> 516K	.
> [p@athena:~/rpmbuild/BUILDROOT/epic5-2.1.2-1.fc32.x86_64/usr/share/doc/epic5] % ls -R | wc -l
> 37

> Again, not sure where these size numbers have come from!

> [p@athena:~/rpmbuild/BUILDROOT/epic5-2.1.2-1.fc32.x86_64/usr/share] % du -sh .
> 1.1M	.

Thanks for double-checking this! Don't worry about the sizes then.

> I'm not too sure why this is failing?

There are some issues related to annobin, I think. I had to jump through a
couple of hoops in my recent reviews as well.

Also, and this is totally my fault, according to the licensing guidelines
(https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses),
"GPL" alone is not a valid license. It should say "GPL+", which translates to
"A GPL or LGPL licensed package that lacks any statement of what version that
it's licensed under".

As a last check I ran extra Koji builds for Fedora 32 and 33 - all clear:
- https://koji.fedoraproject.org/koji/taskinfo?taskID=47886526
- https://koji.fedoraproject.org/koji/taskinfo?taskID=47886434

Package approved! You just need a sponsor now :).


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux