https://bugzilla.redhat.com/show_bug.cgi?id=1842662 Antonio T. sagitter <trpost@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |182235 (FE-Legal) --- Comment #4 from Antonio T. sagitter <trpost@xxxxxxxxxxxxxx> --- SPEC: https://download.copr.fedorainfracloud.org/results/sagitter/ForTesting/fedora-rawhide-x86_64/01517626-ismrmrd/ismrmrd.spec SRPM: https://download.copr.fedorainfracloud.org/results/sagitter/ForTesting/fedora-rawhide-x86_64/01517626-ismrmrd/ismrmrd-1.4.2.1-2.fc33.src.rpm (In reply to Fabian Affolter from comment #1) > - The license seems to be "ISMRMRD SOFTWARE LICENSE JULY 2013" according > LICENSE. Should be a MIT license. Good for Fedora. > One file contains a MPL header [1]. Can you please check this? > > - Link to upstream source of the *-make.patch is missing. > > Otherwise looks good to me. > > [1] > https://github.com/ismrmrd/ismrmrd/blob/ > 87b6f6b68fd53702f4f36d1a277ed4b9c865cd26/cmake/FindPugiXML.cmake > That's a CMake file, not a source file neither a file needed in runtime. Listing its license is not necessary. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=182235 [Bug 182235] Fedora Legal Tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
