[Bug 1853629] Review Request: perl-Color-RGB-Util - Utilities related to RGB colors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1853629

Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
                 CC|                            |zebob.m@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |zebob.m@xxxxxxxxx
              Flags|                            |fedora-review+



--- Comment #1 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> ---
URL and Source addresses are Ok.
Source archive (SHA-256:
4ff8ef2433c2e3fe2cf3730ca41b28617d8e80a860ddedba7e8cdbe17dd5972d) is original.
Ok.
Summary verified from lib/Color/RGB/Util.pm. Ok.
Description verified. Ok.
License verified from README and lib/Color/RGB/Util.pm. Ok.
No XS code, noarch BuildArch is Ok.

Pod::Coverage::TrustPod, Test::Pod::Coverage, Test::Perl::Critic, and Test::Pod
are not used. Ok.
AUTHOR_TESTING variable is unset before executing "make test". Ok.


#   Failed test 'Color/RGB/Util.pm loaded ok'
#   at t/00-compile.t line 43.
#          got: '512'
#     expected: '0'
Can't locate blib.pm in @INC (you may need to install the blib module) (@INC
contains: /builddir/build/BUILD/Color-RGB-Util-0.601/blib/lib
/builddir/build/BUILD/Color-RGB-Util-0.601/blib/arch
/usr/local/lib64/perl5/5.32 /usr/local/share/perl5/5.32
/usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5
/usr/share/perl5 .).
BEGIN failed--compilation aborted.


⇒ blib.pm is not provided by perl-interpreter anymore but by perl-blib

BuildRequires:  perl(blib)

$ rpmlint perl-Color-RGB-Util.spec
review-perl-Color-RGB-Util/results/perl-Color-RGB-Util-0.601-1.fc33.noarch.rpm 
review-perl-Color-RGB-Util/results/perl-Color-RGB-Util-0.601-1.fc33.src.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

$ rpm -q -lv -p
review-perl-Color-RGB-Util/results/perl-Color-RGB-Util-0.601-1.fc33.noarch.rpm 
                     12:25:30
drwxr-xr-x    2 root     root                        0 Jul  4 12:24
/usr/share/doc/perl-Color-RGB-Util
-rw-r--r--    1 root     root                     2109 Jun  8 07:14
/usr/share/doc/perl-Color-RGB-Util/Changes
-rw-r--r--    1 root     root                    10721 Jun  8 07:14
/usr/share/doc/perl-Color-RGB-Util/README
drwxr-xr-x    2 root     root                        0 Jul  4 12:24
/usr/share/licenses/perl-Color-RGB-Util
-rw-r--r--    1 root     root                    18457 Jun  8 07:14
/usr/share/licenses/perl-Color-RGB-Util/LICENSE
-rw-r--r--    1 root     root                     4861 Jul  4 12:24
/usr/share/man/man3/Color::RGB::Util.3pm.gz
drwxr-xr-x    2 root     root                        0 Jul  4 12:24
/usr/share/perl5/vendor_perl/Color
drwxr-xr-x    2 root     root                        0 Jul  4 12:24
/usr/share/perl5/vendor_perl/Color/RGB
-rw-r--r--    1 root     root                    23426 Jun  8 07:14
/usr/share/perl5/vendor_perl/Color/RGB/Util.pm
File layout ans permissions are Ok.


$ rpm -q --requires -p
review-perl-Color-RGB-Util/results/perl-Color-RGB-Util-0.601-1.fc33.noarch.rpm
| sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.32.0)
      1 perl(:VERSION) >= 5.10.1
      1 perl(Digest::SHA)
      1 perl(Exporter) >= 5.57
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsZstd) <= 5.4.18-1
Binary requires are Ok.


$ rpm -q --provides -p
review-perl-Color-RGB-Util/results/perl-Color-RGB-Util-0.601-1.fc33.noarch.rpm
| sort -f | uniq -c
      1 perl(Color::RGB::Util) = 0.601
      1 perl-Color-RGB-Util = 0.601-1.fc33
Binary provides are Ok.


The package builds in Fedora 33
(https://koji.fedoraproject.org/koji/taskinfo?taskID=46564409). Ok.

The package is in line with Fedora and Perl packagaging guidelines.

Resolution: Package approved. Please add the blib dependency before import.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux