[Bug 1842662] Review Request: ismrmrd - ISMRM Raw Data Format (ISMRMRD)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1842662



--- Comment #5 from Fabian Affolter <mail@xxxxxxxxxxxxxxxxxx> ---
(In reply to Antonio T. sagitter from comment #4)
> (In reply to Fabian Affolter from comment #1)
> > - The license seems to be "ISMRMRD SOFTWARE LICENSE JULY 2013" according
> > LICENSE. 
> 
> Should be a MIT license. Good for Fedora.

No, it's not. It looks like a variant of MIT that is not listed
(https://fedoraproject.org/wiki/Licensing:MIT).

I'm no licensing expert, let's wait till FE-Legal is lifted.

> > One file contains a MPL header [1]. Can you please check this?
> > [1]
> > https://github.com/ismrmrd/ismrmrd/blob/
> > 87b6f6b68fd53702f4f36d1a277ed4b9c865cd26/cmake/FindPugiXML.cmake
> > 
> 
> That's a CMake file, not a source file neither a file needed in runtime.
> Listing its license is not necessary.

It's part of the source. If there is not need for the file remove it.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux