[Bug 1828205] Review Request: doctest - fast header-only C++ unit testing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1828205

Nick Black <dank@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(dank@xxxxxxxxx)   |



--- Comment #10 from Nick Black <dank@xxxxxxxxx> ---
> *sigh*

you and me both, buddy

Yeah, I was expecting /usr/share/cmake/Modules to work, as there are a bunch of
other .cmake files in there. I expected it enough that I went and verified in
the CMake source that, yes, it is looking for particular shipped files there,
and doing searches for find_package() only in the directories enumerated above.
Sorry :/.

On the "plus" side, this is the right thing to do anyway, because those cmake
files have /usr/lib64 references in them as installed. So this was never
properly a noarch package.

I don't see any means to disable particular warnings like Lintian, alas.

> That means dropping the noarch thing and adding back the %global to disable debuginfo generation.  Put the %global at the top of the spec file.   And then just use %{_libdir} since that expands correctly to /usr/lib or /usr/lib64.

Done.


Validated specfile  and grabbed sources with `spectool -g`
Built SRPM with `rpmbuild -bs`
Built RPM+SRPM with `mock -r fedora-rawhide-x86_64 --rebuild`
Installed `doctest-devel` x86_64 RPM, verified that doctest was discovered by
CMake
Removed `doctest-devel`, verified that all residue was clean
rpmlint complains: W: only-non-binary-in-usr-lib


[vps](0) $ sha256sum *doctest*
2f478adeb87cf8444fffdb01ab4de54e64c12b807842275cf2325dc4c8512f9f 
doctest-devel-2.3.7-1.fc33.src.rpm
9667ee059437b8fe84ac1a8aab3b4a38e832c8528dfd50e02793cb6a3af718da 
doctest-devel-2.3.7-1.fc33.x86_64.rpm
[vps](0) $


https://www.dsscaw.com/repos/dnf/doctest-devel-2.3.7-1.fc33.src.rpm

PTAL


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux