https://bugzilla.redhat.com/show_bug.cgi?id=1824848 --- Comment #9 from Artur Iwicki <fedora@xxxxxxxxxx> --- The binary RPM link is not needed. The spec should be provided as a link, instead of being pasted here. Either way, here's my nitpicking: >Summary: This tool serializes the output of popular command line tools and filetypes to structured JSON output The summary text should be no longer than 80 characters. Maybe "Serialize the output of command line tools and filetypes to structured JSON"? https://docs.fedoraproject.org/en-US/packaging-guidelines/#_summary_and_description >%description >JSON CLI output utilityjc is used to JSONify the output of many standard linux >cli tools and file types for easier parsing in scripts. >... >%description -n python3-%{pypi_name} >JSON CLI output utilityjc is used to JSONify the output of many standard linux >cli tools and file types for easier parsing in scripts. 1. "utilityjc" - missing space 2. "cli tools" - please use "CLI" 3. Consider putting the description into a macro (i.e. %global macro_name macro_body), so you don't have to repeat this text in the spec and just use the macro instead. >%{?python_provide:%python_provide python3-%{pypi_name}} I believe this is not needed; it will get auto-generated. https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_automatic_provides_with_a_standardized_name >Requires: python3dist(pygments) >= 2.4.2 >Requires: python3dist(ruamel.yaml) >= 0.15 >Requires: python3dist(setuptools) >Requires: python3dist(xmltodict) >= 0.12 Again, these are not needed; the automatic Python dependency generator should pick these up for you. https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_automatically_generated_dependencies -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
