https://bugzilla.redhat.com/show_bug.cgi?id=1828205 Vitaly Zaitsev <vitaly@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vitaly@xxxxxxxxxxxxxx --- Comment #11 from Vitaly Zaitsev <vitaly@xxxxxxxxxxxxxx> --- Are you still interested in this package? If not, I will take it for myself. I need this package ASAP to build another as a strict dependency. > Source2: https://nick-black.com/dankamongmen.gpg 1. You cannot use your own GPG signatures. You should verify tarballs **only** if upstream provide valid signed tarballs. The doctest upstream don't do this => you must not check anything. > %setup -q -n doctest-%{version} 2. Replace by %autosetup. > mkdir -p %{buildroot}/%{_docdir}/doctest 3. Remove this row and use only %doc directive. 4. Also I suggest to use ninja instead of legacy makefiles: %prep %autosetup -p1 mkdir -p %{_target_platform} %build pushd %{_target_platform} %cmake -G Ninja \ -DCMAKE_BUILD_TYPE=Release \ -DDOCTEST_WITH_MAIN_IN_STATIC_LIB:BOOL=OFF \ -DDOCTEST_WITH_TESTS:BOOL=ON \ .. popd %ninja_build -C %{_target_platform} %install %ninja_install -C %{_target_platform} Check my SPEC: https://raw.githubusercontent.com/EasyCoding/doctest/master/doctest.spec 5. Enable tests: %check pushd %{_target_platform} ctest --output-on-failure popd > I don't see why cmake can't also read /usr/share/cmake in addition to /usr/lib/cmake but I guess I shouldn't be surprised. You must use arched package to verify that all tests will pass on all architectures. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
