https://bugzilla.redhat.com/show_bug.cgi?id=1795470 --- Comment #11 from Fabio Valentini <decathorpe@xxxxxxxxx> --- One final issue: - Package must not depend on deprecated() packages. Note: maven-project is deprecated, you must not depend on it. Two final comments: - Double check that the upgrade path from the old antlr4 package is working. I think the names of the produced binary RPMs are the same, so everything should be good (but please verify). - Make sure to include the trailing slash for the egg-info directory in the python3 subpackage's %files list. Otherwise, looks good. A koji scratch build on rawhide worked as well. → If possible, remove the dependency on maven-project. If that's not possible, we can let the deprecated dependency slide since this is a renamed and not a new package. You could try either removing the dependency, or replacing it with maven-parent, which is (I think) what superseded it with recent versions. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: This is expected for swift libraries. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. Note: Expected co-ownership of common go paths. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [?]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [-]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: antlr4-runtime-test-annotations-4.8-2.fc32.noarch.rpm antlr4-runtime-test-annotation-processors-4.8-2.fc32.noarch.rpm antlr4-runtime-4.8-2.fc32.noarch.rpm antlr4-4.8-2.fc32.noarch.rpm antlr4-maven-plugin-4.8-2.fc32.noarch.rpm antlr4-javadoc-4.8-2.fc32.noarch.rpm antlr4-doc-4.8-2.fc32.noarch.rpm antlr4-cpp-runtime-4.8-2.fc32.x86_64.rpm antlr4-cpp-runtime-devel-4.8-2.fc32.x86_64.rpm golang-antlr4-runtime-devel-4.8-2.fc32.noarch.rpm mono-antlr4-runtime-4.8-2.fc32.noarch.rpm python3-antlr4-runtime-4.8-2.fc32.noarch.rpm swift-antlr4-runtime-4.8-2.fc32.x86_64.rpm antlr4-project-debugsource-4.8-2.fc32.x86_64.rpm antlr4-project-4.8-2.fc32.src.rpm antlr4-runtime-test-annotations.noarch: W: spelling-error %description -l en_US parsers -> parser, parses, parers antlr4-runtime-test-annotations.noarch: W: no-documentation antlr4-runtime-test-annotation-processors.noarch: W: spelling-error %description -l en_US parsers -> parser, parses, parers antlr4-runtime-test-annotation-processors.noarch: W: no-documentation antlr4-runtime.noarch: W: spelling-error %description -l en_US parsers -> parser, parses, parers antlr4.noarch: W: no-manual-page-for-binary antlr4 antlr4-maven-plugin.noarch: W: spelling-error %description -l en_US parsers -> parser, parses, parers antlr4-maven-plugin.noarch: W: no-documentation antlr4-cpp-runtime.x86_64: W: spelling-error %description -l en_US parsers -> parser, parses, parers antlr4-cpp-runtime-devel.x86_64: W: spelling-error Summary(en_US) parsers -> parser, parses, parers antlr4-cpp-runtime-devel.x86_64: W: spelling-error %description -l en_US parsers -> parser, parses, parers golang-antlr4-runtime-devel.noarch: W: spelling-error %description -l en_US parsers -> parser, parses, parers golang-antlr4-runtime-devel.noarch: W: no-documentation golang-antlr4-runtime-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/antlr/antlr4/runtime/Go/antlr/.goipath mono-antlr4-runtime.noarch: W: spelling-error %description -l en_US parsers -> parser, parses, parers mono-antlr4-runtime.noarch: W: only-non-binary-in-usr-lib python3-antlr4-runtime.noarch: W: spelling-error %description -l en_US parsers -> parser, parses, parers python3-antlr4-runtime.noarch: W: no-manual-page-for-binary pygrun swift-antlr4-runtime.x86_64: W: spelling-error %description -l en_US parsers -> parser, parses, parers swift-antlr4-runtime.x86_64: W: no-documentation antlr4-project.src:10: E: hardcoded-library-path in %{_prefix}/lib/swift/linux antlr4-project.src:299: E: hardcoded-library-path in %{_prefix}/lib 15 packages and 0 specfiles checked; 2 errors, 20 warnings. Rpmlint (installed packages) ---------------------------- antlr4-javadoc.noarch: W: invalid-url URL: http://www.antlr.org/ <urlopen error [Errno -2] Name or service not known> swift-antlr4-runtime.x86_64: W: spelling-error %description -l en_US parsers -> parser, parses, parers swift-antlr4-runtime.x86_64: W: invalid-url URL: http://www.antlr.org/ <urlopen error [Errno -2] Name or service not known> swift-antlr4-runtime.x86_64: W: no-documentation antlr4-project-debugsource.x86_64: W: invalid-url URL: http://www.antlr.org/ <urlopen error [Errno -2] Name or service not known> mono-antlr4-runtime.noarch: W: spelling-error %description -l en_US parsers -> parser, parses, parers mono-antlr4-runtime.noarch: W: invalid-url URL: http://www.antlr.org/ <urlopen error [Errno -2] Name or service not known> mono-antlr4-runtime.noarch: W: only-non-binary-in-usr-lib antlr4-runtime.noarch: W: spelling-error %description -l en_US parsers -> parser, parses, parers antlr4-runtime.noarch: W: invalid-url URL: http://www.antlr.org/ <urlopen error [Errno -2] Name or service not known> antlr4-maven-plugin.noarch: W: spelling-error %description -l en_US parsers -> parser, parses, parers antlr4-maven-plugin.noarch: W: invalid-url URL: http://www.antlr.org/ <urlopen error [Errno -2] Name or service not known> antlr4-maven-plugin.noarch: W: no-documentation antlr4-runtime-test-annotations.noarch: W: spelling-error %description -l en_US parsers -> parser, parses, parers antlr4-runtime-test-annotations.noarch: W: invalid-url URL: http://www.antlr.org/ <urlopen error [Errno -2] Name or service not known> antlr4-runtime-test-annotations.noarch: W: no-documentation antlr4.noarch: W: invalid-url URL: http://www.antlr.org/ <urlopen error [Errno -2] Name or service not known> antlr4.noarch: W: no-manual-page-for-binary antlr4 antlr4-cpp-runtime-devel.x86_64: W: spelling-error Summary(en_US) parsers -> parser, parses, parers antlr4-cpp-runtime-devel.x86_64: W: spelling-error %description -l en_US parsers -> parser, parses, parers antlr4-cpp-runtime-devel.x86_64: W: invalid-url URL: http://www.antlr.org/ <urlopen error [Errno -2] Name or service not known> antlr4-runtime-test-annotation-processors.noarch: W: spelling-error %description -l en_US parsers -> parser, parses, parers antlr4-runtime-test-annotation-processors.noarch: W: invalid-url URL: http://www.antlr.org/ <urlopen error [Errno -2] Name or service not known> antlr4-runtime-test-annotation-processors.noarch: W: no-documentation antlr4-cpp-runtime.x86_64: W: spelling-error %description -l en_US parsers -> parser, parses, parers antlr4-cpp-runtime.x86_64: W: invalid-url URL: http://www.antlr.org/ <urlopen error [Errno -2] Name or service not known> antlr4-doc.noarch: W: invalid-url URL: http://www.antlr.org/ <urlopen error [Errno -2] Name or service not known> python3-antlr4-runtime.noarch: W: spelling-error %description -l en_US parsers -> parser, parses, parers python3-antlr4-runtime.noarch: W: invalid-url URL: http://www.antlr.org/ <urlopen error [Errno -2] Name or service not known> python3-antlr4-runtime.noarch: W: no-manual-page-for-binary pygrun golang-antlr4-runtime-devel.noarch: W: spelling-error %description -l en_US parsers -> parser, parses, parers golang-antlr4-runtime-devel.noarch: W: invalid-url URL: http://www.antlr.org/ <urlopen error [Errno -2] Name or service not known> golang-antlr4-runtime-devel.noarch: W: no-documentation golang-antlr4-runtime-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/antlr/antlr4/runtime/Go/antlr/.goipath 14 packages and 0 specfiles checked; 0 errors, 34 warnings. Unversioned so-files -------------------- swift-antlr4-runtime: /usr/lib/swift/linux/libAntlr4.so Source checksums ---------------- https://github.com/antlr/antlr4/archive/4.8/antlr4-4.8.tar.gz : CHECKSUM(SHA256) this package : 992d52444b81ed75e52ea62f9f38ecb7652d5ce2a2130af143912b3042a6d77e CHECKSUM(SHA256) upstream package : 992d52444b81ed75e52ea62f9f38ecb7652d5ce2a2130af143912b3042a6d77e Requires -------- antlr4-runtime-test-annotations (rpmlib, GLIBC filtered): java-headless javapackages-filesystem antlr4-runtime-test-annotation-processors (rpmlib, GLIBC filtered): antlr4-runtime-test-annotations java-headless javapackages-filesystem mvn(com.sun:tools) mvn(org.antlr:antlr4-runtime-test-annotations) antlr4-runtime (rpmlib, GLIBC filtered): java-headless javapackages-filesystem antlr4 (rpmlib, GLIBC filtered): /usr/bin/bash antlr4-runtime java-headless javapackages-filesystem mvn(com.ibm.icu:icu4j) mvn(com.sun:tools) mvn(javax.json:javax.json-api) mvn(org.abego.treelayout:org.abego.treelayout.core) mvn(org.antlr:ST4) mvn(org.antlr:antlr-runtime) mvn(org.antlr:antlr4-runtime) mvn(org.glassfish:javax.json) antlr4-maven-plugin (rpmlib, GLIBC filtered): antlr4 java-headless javapackages-filesystem mvn(org.antlr:antlr4) mvn(org.apache.maven:maven-plugin-api) mvn(org.apache.maven:maven-project) mvn(org.codehaus.plexus:plexus-compiler-api) mvn(org.sonatype.plexus:plexus-build-api) antlr4-javadoc (rpmlib, GLIBC filtered): javapackages-filesystem antlr4-doc (rpmlib, GLIBC filtered): antlr4-cpp-runtime (rpmlib, GLIBC filtered): ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.4)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.11)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.7)(64bit) rtld(GNU_HASH) antlr4-cpp-runtime-devel (rpmlib, GLIBC filtered): antlr4-cpp-runtime(x86-64) libantlr4-runtime.so.4.8()(64bit) golang-antlr4-runtime-devel (rpmlib, GLIBC filtered): go-filesystem mono-antlr4-runtime (rpmlib, GLIBC filtered): mono(System) mono(System.Core) mono(mscorlib) python3-antlr4-runtime (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) swift-antlr4-runtime (rpmlib, GLIBC filtered): libBlocksRuntime.so()(64bit) libFoundation.so()(64bit) libc.so.6()(64bit) libdispatch.so()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libswiftCore.so()(64bit) libswiftDispatch.so()(64bit) libswiftGlibc.so()(64bit) libutil.so.1()(64bit) rtld(GNU_HASH) antlr4-project-debugsource (rpmlib, GLIBC filtered): Provides -------- antlr4-runtime-test-annotations: antlr4-runtime-test-annotations mvn(org.antlr:antlr4-runtime-test-annotations) mvn(org.antlr:antlr4-runtime-test-annotations:pom:) antlr4-runtime-test-annotation-processors: antlr4-runtime-test-annotation-processors mvn(org.antlr:antlr4-runtime-test-annotation-processors) mvn(org.antlr:antlr4-runtime-test-annotation-processors:pom:) antlr4-runtime: antlr4-runtime mvn(org.antlr:antlr4-master:pom:) mvn(org.antlr:antlr4-runtime) mvn(org.antlr:antlr4-runtime:pom:) osgi(org.antlr.antlr4-runtime) antlr4: antlr4 mvn(org.antlr:antlr4) mvn(org.antlr:antlr4:pom:) antlr4-maven-plugin: antlr4-maven-plugin mvn(org.antlr:antlr4-maven-plugin) mvn(org.antlr:antlr4-maven-plugin:pom:) antlr4-javadoc: antlr4-javadoc antlr4-doc: antlr4-doc antlr4-cpp-runtime: antlr4-cpp-runtime antlr4-cpp-runtime(x86-64) libantlr4-runtime.so.4.8()(64bit) antlr4-cpp-runtime-devel: antlr4-cpp-runtime-devel antlr4-cpp-runtime-devel(x86-64) golang-antlr4-runtime-devel: golang(github.com/antlr/antlr4/runtime/Go/antlr) golang-antlr4-runtime-devel golang-ipath(github.com/antlr/antlr4/runtime/Go/antlr) mono-antlr4-runtime: mono(Antlr4.Runtime.Standard) mono-antlr4-runtime python3-antlr4-runtime: antlr4-python3-runtime python3-antlr4-runtime python3.8dist(antlr4-python3-runtime) python3dist(antlr4-python3-runtime) swift-antlr4-runtime: libAntlr4.so()(64bit) swift-antlr4-runtime swift-antlr4-runtime(x86-64) antlr4-project-debugsource: antlr4-project-debugsource antlr4-project-debugsource(x86-64) Generated by fedora-review 0.7.4 (54fa030) last change: 2019-12-07 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -o --enablerepo local -b 1795470 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Python, Shell-api, Java Disabled plugins: R, Perl, PHP, fonts, Ocaml, Haskell, SugarActivity Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
