https://bugzilla.redhat.com/show_bug.cgi?id=1798811 Jan Staněk <jstanek@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jstanek@xxxxxxxxxx --- Comment #1 from Jan Staněk <jstanek@xxxxxxxxxx> --- Not a proper review, just my 2 cents: > Source0: %{url}/archive/%{version}.tar.gz#/%{name}-%{version}.tar.gz With github, there is no need to use the #-renaming trick for tarballs. Prefer `SourceN: %{url}/archive/%{version}/%{name}-%{version}.tar.gz`. https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_hosting_services > # disable systemd user service by default Maybe I'm missing something, but any service in Fedora is not enabled by default; AFAIK you need a preset file only if you want to enable it without user interaction. Unless you have a compelling reason (in which case I would appreciate a comment in the spec file) to ship the preset, just get rid of it entirely. Also, the unit file presumes the existence of a wayland-session.target, which we do not have in Fedora at the moment – so enabling the service would not have the desired effect of starting the service at login (as far as I can tell). I'm not sure what should be done with that. --- Other than that, it looks good at a glance; thank you for the effort in preparing the package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
