https://bugzilla.redhat.com/show_bug.cgi?id=1795470 --- Comment #12 from Jerry James <loganjerry@xxxxxxxxx> --- (In reply to Fabio Valentini from comment #11) > One final issue: > > - Package must not depend on deprecated() packages. > Note: maven-project is deprecated, you must not depend on it. Okay. However, maven-parent is not the replacement for it, but (in this case at least) maven-core.jar from maven-lib is. This works: %pom_change_dep org.apache.maven:maven-project:2.2.1 org.apache.maven:maven-core:3.6.1 antlr4-maven-plugin > Two final comments: > > - Double check that the upgrade path from the old antlr4 package is working. > I think the names of the produced binary RPMs are the same, so everything > should be good (but please verify). That's easy to do because antlr4 is needed to build itself. It wants its own maven plugin, so the previous version of antlr4 is always pulled into the build root when building a new version. Then just install the newly built RPMs into the build root, and there's your update scenario. I have done this and it works. I have also verified that version 4.8 can bootstrap itself by building it a second time after adding the first build run's RPMs into my local repository. > - Make sure to include the trailing slash for the egg-info directory in the > python3 subpackage's %files list. Added. I also added man pages for the antlr4 and pygrun binaries, produced with help2man. New URLs: Spec URL: https://jjames.fedorapeople.org/antlr4-project/antlr4-project.spec SRPM URL: https://jjames.fedorapeople.org/antlr4-project/antlr4-project-4.8-3.fc32.src.rpm RPMLINTRC URL: https://jjames.fedorapeople.org/antlr4-project/antlr4-project.rpmlintrc -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
