https://bugzilla.redhat.com/show_bug.cgi?id=1785069 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx Summary|Review request: Lector -- |Review request: lector -- |ebook reader and collection |ebook reader and collection |manager |manager --- Comment #2 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - Why isn't it noarch? BuildArch: noarch - %global debug_package %{nil} shouldn't be needed with noarch - package it? ## TODO: Python DjVuLibre (for reading DjVu documents) isn't packaged at all yet for Fedora 30. # Requires: python3-djvulibre >= 0.8.4 It need to be resurrected https://src.fedoraproject.org/rpms/python-djvulibre ## TODO: Python Markdown (for reading Markdown files) version 3.0.1 isn't in Fedora 30 yet...? It is in F31 and F32. Use a Recommends here if you need. - Capitalize the Summary Summary: Ebook reader and collection manager - Requires: hicolor-icon-theme to own icons directory - Python requires are not necessary, they are autodetected on Fedora (not EPEL) - You need to validate the desktop file in %install or %check: desktop-file-validate %{buildroot}/%{_datadir}/applications/lector.desktop - Consider providing an Appdata file https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/ - Using only: BuildRequires: python3-devel BuildRequires: python3dist(setuptools) BuildRequires: python3dist(beautifulsoup4) >= 4.6.0 BuildRequires: python3dist(pyqt5) >= 5.10 BuildRequires: python3dist(python-poppler-qt5) >= 0.24.2 Requires: python3dist(pyqt5) >= 5.10 Requires: python3dist(python-poppler-qt5) >= 0.24.2 Requires: python3dist(lxml) >= 4.2 Requires: python3dist(pymupdf) >= 1.14.5 Requires: python3dist(textile) >= 3.0.4 Requires: python3dist(xmltodict) >= 0.11.0 Recommends: python3dist(markdown) >= 2.6.11 Recommends: python3dist(python-djvulibre) >= 0.8.4 should be sufficient. - The rar License should be included too: # Main program: GPLv3 # rarfile: MIT License: GPLv3 and MIT - Translations don't seem to work, ask upstream about it? - latest version for "python3dist(python-poppler-qt5)" is 0.24.1 I don't know? rpm -q --provides -p python3-poppler-qt5-0.24.2-15.fc31.x86_64.rpm python3-poppler-qt5 = 0.24.2-15.fc31 python3-poppler-qt5(x86-64) = 0.24.2-15.fc31 python3.7dist(python-poppler-qt5) = 0.24.1 python3dist(python-poppler-qt5) = 0.24.1 It seems the package info generated from setup.py, which is used for python3dist, says 0.24.1: Metadata-Version: 1.2 Name: python-poppler-qt5 Version: 0.24.1 Summary: A Python binding to Poppler-Qt5 Home-page: https://github.com/wbsoft/python-poppler-qt5 Maintainer: Wilbert Berendsen Maintainer-email: wbsoft@xxxxxxxxx License: LGPL The error comes from upstream https://github.com/frescobaldi/python-poppler-qt5/blob/v0.24.2/setup.py ========================================================== Name: lector Summary: Ebook reader and collection manager URL: https://github.com/BasioMeusPuga/Lector # Main program: GPLv3 # rarfile: MIT License: GPLv3 and MIT Version: 0.5.1 Release: 1%{?dist} BuildArch: noarch Source0: %url/archive/%{version}/%{name}-%{version}.tar.gz BuildRequires: python3-devel BuildRequires: python3dist(setuptools) BuildRequires: python3dist(beautifulsoup4) >= 4.6.0 BuildRequires: python3dist(pyqt5) >= 5.10 BuildRequires: python3-poppler-qt5 >= 0.24.2 Requires: python3dist(pyqt5) >= 5.10 Requires: python3-poppler-qt5 >= 0.24.2 Requires: python3dist(lxml) >= 4.2^ Requires: python3dist(pymupdf) >= 1.14.5 Requires: python3dist(textile) >= 3.0.4 Requires: python3dist(xmltodict) >= 0.11.0 Recommends: python3dist(markdown) >= 2.6.11 Recommends: python3dist(python-djvulibre) >= 0.8.4 %description Lector is an ebook reader and collection manager. It offers a fullscreen distraction-free view, document highlighting and annotations, a built-in dictionary, bookmarks, and multiple profiles for changing the way the books are presented. Lector can also edit metadata, so you can correct information about the books, and add keywords to make them easier to find. It supports the following file formats: * PDF * EPUB * DjVu * FictionBook (.fb2) * Mobipocket (.mobi) * Amazon Kindle (.azw, .azw3, .azw4) * Comic book archives (.cbr, .cbz) * Markdown %prep %autosetup -n Lector-%{version} %build %py3_build mv ./lector/rarfile/LICENSE ./LICENSE-rarfile %install %py3_install %files %doc AUTHORS README.md %license LICENSE LICENSE-rarfile %{_bindir}/%{name} %{_datadir}/applications/lector.desktop %{_datadir}/icons/hicolor/scalable/apps/Lector.png %{python3_sitelib}/lector* %changelog * Wed Dec 18 2019 Andrew Toskin <andrew@xxxxxxx> - 0.5.1-1 - First (mostly) working build. ========================================================== # python-djvulibre.spec # Created by pyp2rpm-3.3.2 # This package installs two private shared libraries, don't 'provide' them %global __provides_exclude_from ^%{python3_sitearch}/.*\\.so)$ %global pypi_name python-djvulibre %global srcname djvulibre Name: python-%{srcname} Version: 0.8.5 Release: 1%{?dist} Summary: Python support for the DjVu image format License: GPLv2 URL: http://jwilk.net/software/python-djvulibre Source0: %{pypi_source %pypi_name} Source1: https://raw.githubusercontent.com/jwilk/python-djvulibre/master/COPYING BuildRequires: gcc BuildRequires: python3-devel BuildRequires: python3dist(setuptools) BuildRequires: python3dist(sphinx) BuildRequires: python3dist(cython) BuildRequires: python3dist(nose) BuildRequires: djvulibre BuildRequires: pkgconfig(ddjvuapi) %description python-djvulibre is a set of Python bindings for the DjVuLibre library, an open source implementation of DjVu. %package -n python3-%{srcname} Summary: %{summary} %{?python_provide:%python_provide python3-%{srcname}} %description -n python3-%{srcname} python-djvulibre is a set of Python bindings for the DjVuLibre library, an open source implementation of DjVu. %package -n python-%{srcname}-doc Summary: Python-djvulibre documentation BuildArch: noarch %description -n python-%{srcname}-doc Documentation for Python-djvulibre. %prep %autosetup -n %{pypi_name}-%{version} cp %{S:1} . # Make sure scripts in the examples directory aren't executable chmod 0644 examples/* %build %py3_build # generate html docs PYTHONPATH=${PWD} sphinx-build-3 doc/api html # remove the sphinx-build leftovers rm -rf html/.{doctrees,buildinfo} %install %py3_install %check # Remove djvu to import from PYTHONPATH instead of subdirectory rm -rf djvu PYTHONPATH=%{buildroot}%{python3_sitearch} nosetests-%{python3_version} %files -n python3-%{srcname} %license COPYING %{python3_sitearch}/djvu/ %{python3_sitearch}/python_djvulibre-%{version}-py%{python3_version}.egg-info %files -n python-%{srcname}-doc %license COPYING %doc html examples %changelog * Wed Dec 18 2019 Andrew Toskin <andrew@xxxxxxx> - 0.8.5-1 - Initial package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
