[Bug 1785069] Review request: lector -- ebook reader and collection manager

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1785069



--- Comment #3 from Andrew Toskin <andrew@xxxxxxx> ---
Oh, thank you. I hadn't expected any feedback before I announced this package
on the devel mailing list, but I appreciate it :)

> Why isn't it noarch?

I'm vaguely aware that Python is an interpreted language -- or at least, it can
be, depending on the impelementation? -- but I thought that the compiled .pyc
files meant that Python packages on Fedora were architecture-dependent after
all. But I guess maybe not, if it's only byte code for the CPython VM?

> See https://src.fedoraproject.org/rpms/python-djvulibre

Ah, okay. I'd only searched for packages in dnf (and I'm still currently using
Fedora 30 as my main workstation). And I see you included a generated spec for
the DjVuLibre bindings package too. If I can just revive that old package, then
that should make things a bit easier, thanks.

See Bug #1786210.

> python-markdown is in F31 and F32. Use a Recommends here if you need.

Okay, sure. If the maintainer can't or won't backport python-markdown for F30,
then setting that dependency to a Recommend might be good enough... Although,
if I can't get python-lxml backported, there may not be much point in building
Lector for F30 anyway, since users are most likely to expect Epub support.

> Python requires are not necessary, they are autodetected on Fedora (not EPEL)

Well, I do want to support EPEL, if feasible. I'll take a look at building on
CentOS 8 sometime this week, and then we can decide whether to worry about EPEL
stuff.

> Consider providing an Appdata file

Oh, yes, I'll put together the AppData/AppStream files and see if the upstream
is willing to accept them into the main repository...
https://github.com/BasioMeusPuga/Lector/issues/118

> Translations don't seem to work, ask upstream about it?

Okay. If this is possibly a bug in upstream, then I'm not really sure where to
start troubleshooting. So I basically just restate my original questions on
their GitHub... https://github.com/BasioMeusPuga/Lector/issues/117

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux