https://bugzilla.redhat.com/show_bug.cgi?id=1785069 Andrew Toskin <andrew@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value --- Comment #1 from Andrew Toskin <andrew@xxxxxxx> --- This package is of course not ready yet. You will notice several TODO comments throughout the spec file. Most of my prior packaging experience has been with GNOME Shell extensions, so I'm less familiar with working on full GUI applications, or with the Python ecosystem in particular. I'll greatly appreciate any feedback I can get here. * The -debuginfo subpackage would be empty, if allowed to build, but I'm not sure why. I don't *think* this should be a noarch package, since it does compile the .pyc files. And there's no Makefile, and I don't see "strip" mentioned anywhere in the whole source tarball... Could the upstream project just not support debugging binaries...? * Lector's support for DjVu documents requires the Python bindings for DjVuLibre, which isn't in Fedora at all yet. I plan to also submit a package review request for a python3-djvulibre package, but since DjVu documents are relatively uncommon, I'm inclined to let that wait till after Lector is accepted, rather than the other way around. * I'd like for this package to build against Fedora 30, since F30 will be supported for a while still, but proper support for Epub books would require the python3-lxml maintainer to build at least v4.3 for F30. I've submitted that request against the python-lxml package here in Bug #1784998. (If feasible, I'll also build for EPEL 8, though I'm not going to worry too much about it till the other aspects are set.) * Similarly, Lector on Fedora 30 will require backporting python-markdown v3.0.1+. See Bug #1785073. * I tried to use Provides-like namespecs for all dependencies, but on Fedora 30, * latest version for "python3-poppler-qt5" is 0.24.2 * latest version for "python3dist(python-poppler-qt5)" is 0.24.1 which is super confusing. Those are the *same package* how do they have different version numbers? * Lector does seem to support some UI localizations, but I don't know how to build them. Since Lector is based on Qt, I suppose it's probably using Qt Linguist? Because the plain %find_lang macro isn't working. But `--with-qt` doesn't help either. So I've got some reading to do, I guess, but I have no idea how Qt Linguist works, if that's even the localization tool being used here. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
