https://bugzilla.redhat.com/show_bug.cgi?id=1770147 --- Comment #7 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - Add a Summary Summary: None - The point of using %gobuild is that it set the Fedora build flags, %make_build does not. # Easier to use %make_build than %gobuild macro when there is a Makefile. %make_build - Use: Version: 0.4.1 %global tag v0.4.1 with: Source0: %{gosource} - %generate_buildrequires doesn't work that way, it should go after goprep. We don't use it so far in Go packaging. Just put the BR the olld way for now: BuildRequires: golang(github.com/BurntSushi/toml) BuildRequires: golang(gitlab.com/hacklunch/ntp) BuildRequires: golang(gitlab.com/hacklunch/ntske) - Systemd rpm macros do not always exist in CI/CD environment What does this has to do with Fedora? We're packaging in Koji, not in a custom CI/CD environment. - I'm no expert on the SELinux stuff, I need someone to review this. Askk for some help on the devel ML. - This is only usefil for the -devel subpackage, I don't think you need it for a binary package: %gopkg %gopkginstall %gopkgfiles -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
