[Bug 1770147] Review Request: ntsclient - Golang NTS client

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1770147



--- Comment #8 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
 - To expand a bit, your Makefile only contains:


$(BINARY): $(SRCS)
        go build -o $@


 while the %gobuild macro contains Fedora LDFLAGS and also provision for the
debuginfo to be correctly generated:

  # https://bugzilla.redhat.com/show_bug.cgi?id=995136#c12
    %ifnarch ppc64
   GO111MODULE=off \
  go build -buildmode pie -compiler gc -tags="rpm_crashtraceback
${BUILDTAGS:-}" -ldflags "${LDFLAGS:-} -B 0x$(head -c20 /dev/urandom|od -An
-tx1|tr -d ' \n') -extldflags '-Wl,-z,relro -Wl,--as-needed  -Wl,-z,now
-specs=/usr/lib/rpm/redhat/redhat-hardened-ld '" -a -v -x ;
  %else
   GO111MODULE=off \
  go build                -compiler gc -tags="rpm_crashtraceback
${BUILDTAGS:-}" -ldflags "${LDFLAGS:-} -B 0x$(head -c20 /dev/urandom|od -An
-tx1|tr -d ' \n') -extldflags '-Wl,-z,relro -Wl,--as-needed  -Wl,-z,now
-specs=/usr/lib/rpm/redhat/redhat-hardened-ld '" -a -v -x ;
  %endif


 - You need to add:

BuildRequires: systemd-rpm-macros

 for the SystemD scriptlet to work.

 On older Fedora it was:

%{?systemd_requires}
BuildRequires: systemd

 (Not sure what your CI system is using)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux