https://bugzilla.redhat.com/show_bug.cgi?id=1768192 Bug ID: 1768192 Summary: Review Request: git-secrets - Prevents committing secrets and credentials into git repos Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@xxxxxxxxxxxxxxxxx Reporter: kees.dejong+dev@xxxxxxxxxx QA Contact: extras-qa@xxxxxxxxxxxxxxxxx CC: package-review@xxxxxxxxxxxxxxxxxxxxxxx Target Milestone: --- Classification: Fedora Spec URL: https://github.com/AquaL1te/git-secrets/blob/master/git-secrets.spec SRPM URL: https://github.com/AquaL1te/git-secrets/blob/master/git-secrets-1.3.0-1.fc30.src.rpm Description: Prevents you from committing passwords and other sensitive information to a git repository Fedora Account System Username: keesdejong I myself have a few questions. * I encountered this error: "error: Empty %files file /builddir/build/BUILD/git-secrets-1.3.0/debugsourcefiles.list", which I solved by adding this to the top of the spec file: "%global debug_package %{nil}". But the correct way it to set the BuildArch to noarch, correct? * The default prefix is set to /usr/local, I substituted the prefix line in Makefile with a sed command. Is this correct? Or is that a way to override the prefix with e.g. "%_prefix /usr? somewhere in the spec file? * I wrote "repos" instead of repositories, rpmlint complains about it. Is the description in the spec file allowed to exceed 79 characters for this? Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=38729027 Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. Licenses found: "Unknown or generated", "*No copyright* Apache License (v2.0)", "Apache License (v2.0)", "Expat License". 21 files have unknown license. Detailed output of licensecheck in /home/kjong/git/git-secrets/review-git- secrets/licensecheck.txt [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [?]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [?]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [-]: Requires correct, justified where necessary. [?]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [?]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [-]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: git-secrets-1.3.0-1.fc32.x86_64.rpm git-secrets-1.3.0-1.fc32.src.rpm git-secrets.x86_64: W: spelling-error Summary(en_US) repos -> ropes, reps, repose git-secrets.x86_64: W: no-version-in-last-changelog git-secrets.x86_64: E: no-binary git-secrets.src: W: spelling-error Summary(en_US) repos -> ropes, reps, repose git-secrets.src: W: no-version-in-last-changelog git-secrets.src: W: strange-permission git-secrets-1.3.0.tar.gz 640 git-secrets.src: W: strange-permission git-secrets.spec 640 2 packages and 0 specfiles checked; 1 errors, 6 warnings. Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). git-secrets.x86_64: W: spelling-error Summary(en_US) repos -> ropes, reps, repose git-secrets.x86_64: W: no-version-in-last-changelog git-secrets.x86_64: W: invalid-url URL: https://github.com/awslabs/git-secrets/ <urlopen error [Errno -2] Name or service not known> git-secrets.x86_64: E: no-binary 1 packages and 0 specfiles checked; 1 errors, 3 warnings. Source checksums ---------------- https://github.com/awslabs/git-secrets/archive/1.3.0.tar.gz#/git-secrets-1.3.0.tar.gz : CHECKSUM(SHA256) this package : f1d50c6c5c7564f460ff8d279081879914abe920415c2923934c1f1d1fac3606 CHECKSUM(SHA256) upstream package : f1d50c6c5c7564f460ff8d279081879914abe920415c2923934c1f1d1fac3606 Requires -------- git-secrets (rpmlib, GLIBC filtered): /usr/bin/bash Provides -------- git-secrets: git-secrets git-secrets(x86-64) Generated by fedora-review 0.7.3 (44b83c7) last change: 2019-09-18 Command line :/usr/bin/fedora-review -n git-secrets Buildroot used: fedora-rawhide-{{ target_arch }} Active plugins: Generic, Shell-api Disabled plugins: C/C++, Ocaml, Perl, R, Java, Haskell, SugarActivity, fonts, PHP, Python Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
