https://bugzilla.redhat.com/show_bug.cgi?id=1768192 --- Comment #14 from Elliott Sales de Andrade <quantum.analyst@xxxxxxxxx> --- (In reply to Kees de Jong from comment #11) > > You shouldn't use internal macros like %__make; just run make directly. > Is there a reason for this? If the macro exists, then it can be used, right? > I haven't read anything about this in the maintainer guide. I figured, the > macro exists, so that implies it may be used. > No, it's internal, and there's no need to use it. Just because it exists, doesn't mean it should be used. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros > Macro forms of system executables SHOULD NOT be used except when there is a need to allow the location of those executables to be configurable. For example, rm should be used in preference to %{__rm}, but %{__python3} is acceptable. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx