https://bugzilla.redhat.com/show_bug.cgi?id=1768192 --- Comment #11 from Kees de Jong <kees.dejong+dev@xxxxxxxxxx> --- > You shouldn't use internal macros like %__make; just run make directly. Is there a reason for this? If the macro exists, then it can be used, right? I haven't read anything about this in the maintainer guide. I figured, the macro exists, so that implies it may be used. > Also, remember to link both spec and srpm. The links are still the same, but are changed on GitHub. I'll include them now anyway. > If you need git at build time, do you not need it at runtime, too? Also, do you need full git, or can git-core work? Good one! git-core is indeed sufficient too and is indeed also needed for runtime. I've updated the spec file and created new builds: Spec URL: https://github.com/AquaL1te/git-secrets/blob/master/git-secrets.spec SRPM URL: https://github.com/AquaL1te/git-secrets/blob/master/git-secrets-1.3.0-1.fc30.src.rpm Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=40051909 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
