Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: superiotool - Simple program for detecting Super I/O on your mainboard https://bugzilla.redhat.com/show_bug.cgi?id=315351 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review? ------- Additional Comments From panemade@xxxxxxxxx 2007-10-03 05:19 EST ------- Need some changes 1) Preserve timestamp by using -p option check http://fedoraproject.org/wiki/Packaging/Guidelines#head-0239576e441f9ef53d175c4aec8c12868dffb5ab 2) patch name should be superiotool-Makefile_cleanup.diff Remove extra hypen in patch name and apply patch in %setup as %patch -p0 -b .Makefile_cleanup 3) SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. 4) either use macros for all commands install,mkdir or remove macro use for rm, mkdir commands. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review