Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: superiotool - Simple program for detecting Super I/O on your mainboard https://bugzilla.redhat.com/show_bug.cgi?id=315351 ------- Additional Comments From lemenkov@xxxxxxxxx 2007-10-03 05:53 EST ------- (In reply to comment #1) > Need some changes > 1) Preserve timestamp by using -p option Done. > 2) patch name should be superiotool-Makefile_cleanup.diff > Remove extra hypen in patch name and apply patch in %setup as > %patch -p0 -b .Makefile_cleanup Done. > 3) SHOULD: If the source package does not include license text(s) as a separate > file from upstream, the packager SHOULD query upstream to include it. I'll drop a line to linuxbios-maillist later. > 4) either use macros for all commands install,mkdir or remove macro use for rm, > mkdir commands. Done. New svn. version 2818 (slightly changed output of ./superiotool -v command) http://peter.fedorapeople.org/superiotool.spec http://peter.fedorapeople.org/superiotool-0-0.2.20071003svn2818.fc7.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review