https://bugzilla.redhat.com/show_bug.cgi?id=1734161 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #5 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- pushd build %make_build install DESTDIR=$RPM_BUILD_ROOT popd No, use: %make_install -C build - Not needed: %defattr(-,root,root,-) - Use %ldconfig_scriptlets instead of: %post /sbin/ldconfig %postun /sbin/ldconfig - Missing isa: Requires: %{name}%{?_isa} = %{version} - Valid shorthand for Apache 2.0 is ARL 2.0: License: ASL 2.0 - Why do you include: # Generated from: # git archive --prefix "scitokens-cpp-0.3.3/" -o "scitokens-cpp-0.3.3.tar" v0.3.3 # git submodule update --init # git submodule foreach --recursive "git archive --prefix=scitokens-cpp-0.3.3/\$path/ --output=\$sha1.tar HEAD && tar --concatenate --file=$(pwd)/scitokens-cpp-0.3.3.tar \$sha1.tar && rm \$sha1.tar" # gzip "scitokens-cpp-0.3.3.tar" if the source is downloaded from: https://github.com/scitokens/%{name}/archive/%{name}-%{version}.tar.gz Use directly https://github.com/scitokens/scitokens-cpp/releases/download/v%{version}/%{name}-%{version}.tar.gz - In order to avoid unintentional soname bump, we forbid globiing the major soname version: %{_libdir}/libSciTokens.so.0* - You *must* include the LICENSE file in %files with %license and you should include the README.md file with %doc %license LICENSE %doc README.md -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
