https://bugzilla.redhat.com/show_bug.cgi?id=1734161 --- Comment #6 from Derek <djw8605@xxxxxxxxx> --- Thank you all for the great feedback! I have incorporated all of your feedback into the spec file [0] - Using the %make_install macro - Removed the defattr - ldconfig_scriplets does not appear to exist on epel7. The package is will need to support this platform. - Added isa to requires - Renamed ASL license - Those are mostly instructions for up stream how to make a release for this package with RPM in mind. I have added those instructions to the README.md as well. - Updated the source0 line. - Modified the soname globbing. - Added the LICENSE and README.md to the files. [0] https://raw.githubusercontent.com/scitokens/scitokens-cpp/master/rpm/scitokens-cpp.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
