https://bugzilla.redhat.com/show_bug.cgi?id=1734161 --- Comment #4 from Derek <djw8605@xxxxxxxxx> --- Thank you for your comments. I hope I have addressed all of the comments: - devtoolset-8 is required on EPEL6 because the package needs c++11. - We package the header-only jwt-cpp dependency. I made a note in the spec file [0] about the inclusion of jwt-cpp. But, since it's a header-only dependency, it will not be "provided" by the package at the end. - I reworked how to generate the source. Now it is simply a few different steps, git submodule update, ... It is all documented in the spec. - Now calling %make_build [0] https://raw.githubusercontent.com/scitokens/scitokens-cpp/dec05b8a8532f13d2b01371c95347efdf961a7e1/rpm/scitokens-cpp.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
