https://bugzilla.redhat.com/show_bug.cgi?id=1734161 david08741@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david08741@xxxxxxxxx --- Comment #3 from david08741@xxxxxxxxx --- The source contains actually 2 sources, the one is [0] and the other one jwt-cpp. The preferred way is to package both of them separately. If you decide against that, you must at least mentioned that you have bundled jwt-cpp, see [1] I don't think that the script to generate the source is acceptable, as it does not ensure that other people get the same version, that you used. You should ensure that the source is a link that ensures a specific version is returned, such as using the above link to a release or a specific git-commit. Also, you shouldn't invoke make directly, but use %make_build instead, see [2] [0] https://github.com/scitokens/scitokens-cpp/archive/v0.3.3.tar.gz [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling [2] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_parallel_make -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
