[Bug 1717652] Review Request: prusa-slicer - G-code generator for 3D printers (RepRap, Makerbot, Ultimaker etc.)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1717652



--- Comment #5 from Jason Tibbitts <tibbs@xxxxxxxxxxx> ---
Thanks.  Some responses:

I can't imagine that 4.5MB of data in /usr/share/PrusaSlicer is considered
large, given what I see in my /usr/share currently.  It's about 2MB icons
(about 40% of which is images of the prusa printers) and 2MB translations. 
Doesn't seem really worth it to try and split it out when it wouldn't save
anything for any spin or end user system, but if more translations pile in then
it might be worth it.

I mentioned in the initial message that you may see the strange-permissions
thing if running rpmlint directly on the srpm I provided.  My umask is 0770
(because we use the posix ACL schema here where every user has their own group)
and "fedpkg srpm" creates the source package using the on-disk permissions,
which is arguably a bug but not one that matters except that rpmlint complains
for whatever reason.  The packages generated from the buildsystem won't have
that issue.

And yes, the summary is exactly what upstream is currently using, both on their
github repo and in the Debian packaging metadata they maintain (hidden in the
"debian" branch).  I'm not sure what text would be better, though it's pretty
hilarious that it doesn't explicitly mention Prusa.  Just saying "G-code
generator optimized for Prusa printers" would work, I guess, but still assumes
you know what G-code means.  Maybe copying the cura package and using "3D
printer control software optimized for Prusa printers" would be OK.  I think
I'll go with that.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux