https://bugzilla.redhat.com/show_bug.cgi?id=1717652 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #4 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Here are my notes, but they are all suggestions, so consider this APPROVED. Thanks for the hard work! 1. Consider this: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 4526080 bytes in /usr/share 2. Can you reproduce this? prusa-slicer.src: W: strange-permission 07282eb24d027817b4279f59ebbf0d80bac5f950.patch 660 prusa-slicer.src: W: strange-permission patch-expat-includes 660 prusa-slicer.src: W: strange-permission patch-qhull-includes 660 prusa-slicer.src: W: strange-permission prusa-slicer.appdata.xml 660 prusa-slicer.src: W: strange-permission prusa-slicer.desktop 660 prusa-slicer.src: W: strange-permission prusa-slicer.spec 660 prusa-slicer.src: W: strange-permission version_2.0.0.tar.gz 660 3. Also, i suggest to update the summary to something more applicable (this summary is still from slic3r (yes, upstream still has this on GitHub)). ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/PrusaSlicer (fixed in -2) [x]: %build honors applicable compiler flags or justifies otherwise. [-]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [-]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [!]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 4526080 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: prusa-slicer-2.0.0-1.fc31.x86_64.rpm prusa-slicer-debuginfo-2.0.0-1.fc31.x86_64.rpm prusa-slicer-debugsource-2.0.0-1.fc31.x86_64.rpm prusa-slicer-2.0.0-1.fc31.src.rpm prusa-slicer.x86_64: W: spelling-error %description -l en_US mSLA -> ms La, slam, ms-la prusa-slicer.x86_64: W: spelling-error %description -l en_US toolchain -> tool chain, tool-chain, touchline prusa-slicer.x86_64: E: incorrect-fsf-address /usr/share/licenses/prusa-slicer/COPYING-avrdude prusa-slicer.x86_64: W: no-manual-page-for-binary prusa-slicer prusa-slicer.src: W: spelling-error %description -l en_US mSLA -> ms La, slam, ms-la prusa-slicer.src: W: spelling-error %description -l en_US toolchain -> tool chain, tool-chain, touchline prusa-slicer.src: W: strange-permission 07282eb24d027817b4279f59ebbf0d80bac5f950.patch 660 prusa-slicer.src: W: strange-permission patch-expat-includes 660 prusa-slicer.src: W: strange-permission patch-qhull-includes 660 prusa-slicer.src: W: strange-permission prusa-slicer.appdata.xml 660 prusa-slicer.src: W: strange-permission prusa-slicer.desktop 660 prusa-slicer.src: W: strange-permission prusa-slicer.spec 660 prusa-slicer.src: W: strange-permission version_2.0.0.tar.gz 660 prusa-slicer.src:137: W: unversioned-explicit-provides bundled(boost-nowide) prusa-slicer.src:141: W: unversioned-explicit-provides bundled(igl) prusa-slicer.src:152: W: unversioned-explicit-provides bundled(mesa-libGLU) prusa-slicer.src:174: W: unversioned-explicit-provides bundled(nanosvg) prusa-slicer.src:188: W: unversioned-explicit-provides bundled(polypartition) 4 packages and 0 specfiles checked; 1 errors, 17 warnings. Rpmlint (debuginfo) ------------------- Checking: prusa-slicer-debuginfo-2.0.0-1.fc31.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- prusa-slicer.x86_64: W: spelling-error %description -l en_US mSLA -> ms La, slam, ms-la prusa-slicer.x86_64: W: spelling-error %description -l en_US toolchain -> tool chain, tool-chain, touchline prusa-slicer.x86_64: W: invalid-url URL: https://github.com/prusa3d/PrusaSlicer/ <urlopen error [Errno -2] Name or service not known> prusa-slicer.x86_64: E: incorrect-fsf-address /usr/share/licenses/prusa-slicer/COPYING-avrdude prusa-slicer.x86_64: W: no-manual-page-for-binary prusa-slicer 3 packages and 0 specfiles checked; 1 errors, 6 warnings. Source checksums ---------------- https://github.com/prusa3d/PrusaSlicer/archive/version_2.0.0.tar.gz : CHECKSUM(SHA256) this package : 5d3c7fd745f2875be55f316cd779805ce1b6ce38634f0f4b0ccd01884da731b3 CHECKSUM(SHA256) upstream package : 5d3c7fd745f2875be55f316cd779805ce1b6ce38634f0f4b0ccd01884da731b3 Requires -------- prusa-slicer (rpmlib, GLIBC filtered): hicolor-icon-theme ld-linux-x86-64.so.2()(64bit) libGL.so.1()(64bit) libGLEW.so.2.1()(64bit) libGLU.so.1()(64bit) libboost_filesystem.so.1.69.0()(64bit) libboost_locale.so.1.69.0()(64bit) libboost_log.so.1.69.0()(64bit) libboost_regex.so.1.69.0()(64bit) libboost_thread.so.1.69.0()(64bit) libc.so.6()(64bit) libcurl.so.4()(64bit) libexpat.so.1()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libminiz.so.0.2()(64bit) libnlopt.so.0()(64bit) libpoly2tri.so.1.0()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libtbb.so.2()(64bit) libwx_baseu-3.0.so.0()(64bit) libwx_baseu-3.0.so.0(WXU_3.0)(64bit) libwx_gtk3u_adv-3.0.so.0()(64bit) libwx_gtk3u_adv-3.0.so.0(WXU_3.0)(64bit) libwx_gtk3u_adv-3.0.so.0(WXU_3.0.3)(64bit) libwx_gtk3u_core-3.0.so.0()(64bit) libwx_gtk3u_core-3.0.so.0(WXU_3.0)(64bit) libwx_gtk3u_gl-3.0.so.0()(64bit) libwx_gtk3u_gl-3.0.so.0(WXU_3.0)(64bit) libwx_gtk3u_html-3.0.so.0()(64bit) libwx_gtk3u_html-3.0.so.0(WXU_3.0)(64bit) rtld(GNU_HASH) prusa-slicer-debuginfo (rpmlib, GLIBC filtered): prusa-slicer-debugsource (rpmlib, GLIBC filtered): Provides -------- prusa-slicer: PrusaSlicer application() application(prusa-slicer.desktop) bundled(admesh-libs) bundled(agg) bundled(avrdude) bundled(boost-nowide) bundled(igl) bundled(imgui) bundled(libnest2d) bundled(mesa-libGLU) bundled(miniz) bundled(nanosvg) bundled(polyclipping) bundled(polypartition) bundled(qhull) bundled(semver) bundled(shinyprofiler) metainfo() metainfo(prusa-slicer.appdata.xml) prusa-slicer prusa-slicer(x86-64) slic3r-prusa3d prusa-slicer-debuginfo: debuginfo(build-id) prusa-slicer-debuginfo prusa-slicer-debuginfo(x86-64) prusa-slicer-debugsource: prusa-slicer-debugsource prusa-slicer-debugsource(x86-64) Generated by fedora-review 0.7.0 (fed5495) last change: 2019-03-17 Command line :try-fedora-review -b 1717652 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Ocaml, fonts, SugarActivity, Python, PHP, R, Java, Perl, Ruby, Haskell Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
