[Bug 1714620] Review Request: miller - name-indexed data processing tool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1714620

Artur Iwicki <fedora@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora@xxxxxxxxxx



--- Comment #2 from Artur Iwicki <fedora@xxxxxxxxxx> ---
>mlr.spec
>Name: miller
The filename of the spec should match the name of the package.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_spec_file_naming

>Group: Applications/Text
>Buildroot: %{_tmppath}/%{name}-%{version}-root
>...
>%clean
Not used in Fedora.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections

>%install
>rm -rf ${RPM_BUILD_ROOT}
Don't do this.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections

>%files
>%{_mandir}/man1/mlr.1.gz
Do not assume that man pages will be compressed using gzip. Use a wildcard
instead.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages

>%defattr(755, root, root, -)
>%defattr(644, root, root, -)
These are discouraged and usually not needed.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_permissions

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux