https://bugzilla.redhat.com/show_bug.cgi?id=1692166 Björn Persson <bjorn@xxxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(bjorn@xn--rombobj | |rn-67a.se) | --- Comment #11 from Björn Persson <bjorn@xxxxxxxxxxxxxxxxxxxx> --- (In reply to Richard W.M. Jones from comment #10) > - If your application is a C or C++ application you must list a > BuildRequires against gcc, gcc-c++ or clang. > Note: No gcc, gcc-c++ or clang found in BuildRequires gcc-gnat pulls in gcc, and wouldn't work without it. Both Ada and C sources are compiled by invoking gcc, the compiler driver, which in turn invokes the actual compiler gnat1 for Ada or cc1 for C. If the GCC packaging would be changed to make cc1 an optional component, in a "gcc-c" package perhaps, then I might need to require that package, but as it currently is, GNAT comes with C support included. I could add "BuildRequires: gcc", but it would be purely a formality. > GPL (with incorrect FSF address) > -------------------------------- > gnatcoll-db-gpl-2018-src/sqlite/gnatcoll-sql-sqlite.adb I'm trying to bring this to Adacore's attention here: https://github.com/AdaCore/gnatcoll-db/pull/11 > Almost every other source file lacks a license header of any kind. On the contrary, almost every source file contains a license header, but Licensecheck apparently doesn't recognize them. > [-]: %build honors applicable compiler flags or justifies otherwise. > > Not really applicable for this Ada package. Actually the entire value of optflags is included in GPRbuild_optflags, and is applied to both Ada and C (although some of the options make no difference for Ada). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
