https://bugzilla.redhat.com/show_bug.cgi?id=1714620 --- Comment #3 from Stephen Kitt <skitt@xxxxxxxxxx> --- Thanks for the review! (In reply to Artur Iwicki from comment #2) > >mlr.spec > >Name: miller > The filename of the spec should match the name of the package. > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_spec_file_naming Fixed, thanks (I checked with upstream, using “miller” as the package name is fine and matches other distributions). I fixed all the other issues you flagged, plus a few more which I noticed from reviewing the packaging guide (which I hadn’t read for a while, mea culpa): * enable hardened build options * use %make macros as appropriate * install the license and README * fix the changelog The upstream PR to fix the .spec file is at https://github.com/johnkerl/miller/pull/249 (but the diff there is useless, too much has changed), and I’ve updated the files on http://sk2.org/miller/ rpmlint only complains about spelling (“mlr”, “sed”, “awk”), and the automated tests in fedora-review didn’t highlight anything amiss. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
