[Bug 1540335] Review Request: primesieve - Fast C/C++ prime number generator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1540335



--- Comment #13 from Petr Menšík <pemensik@xxxxxxxxxx> ---
(In reply to Jani Juhani Sinervo from comment #11)
> (In reply to Kim Walisch from comment #10)
> > Thanks for your review.
> 
> > The Rpmlint spelling-error warnings are false positives.
> 
> Oh, good to know for future reference! I was actually thinking if that would
> actually affect the review outcome significantly in an actual review. I
> included it as a "problem" in that preliminary review just in case.
> 
> --
> 
> But yeah, with the fix to the ldconfig problem sorted, and updating to the
> new version, I'd see no problems with this being included. But I'll leave
> the decision for someone less amateurish than I. But while we wait for an
> official review, here's an updated preliminary review for this new version.
> 

I think your review was a good one, there is no need for package to be perfect.
It met basic requirements, you did review it well. Please, do not be afraid
giving it approval next time. It would not provide sponsor, but mark is as
acceptable. We can always submit bugs to fix not important issues.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux