[Bug 1695139] Review Request: xonsh - A general purpose, Python-ish shell

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1695139



--- Comment #14 from Carmen Bianca Bakker <carmenbianca@xxxxxxxxxxxxxxxxx> ---
I found the problem(s):

- The tests very specifically need to be run within a xonsh shell using the
`py.test-3` command. Calling `py.test-3` from bash or calling `python3 -m
pytest` from xonsh results in failing tests.

- There is an error in `%{_bindir}/xon.sh`.

- The tests in the tarball are incomplete. i.e., files are missing.

I have submitted merge requests upstream for the last two bullet points:

- https://github.com/xonsh/xonsh/pull/3068

- https://github.com/xonsh/xonsh/pull/3069

This is a WIP specfile that doesn't currently build because of failing tests,
but would run if upstream released those fixes (I think):
https://gitlab.com/snippets/1844781

Should we wait for upstream to release the fixes?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux