https://bugzilla.redhat.com/show_bug.cgi?id=1694278 --- Comment #3 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- We have no other choice than to trust that upstream won't rewrite their Github history. Thousands of packages already depend on Github archive links. Source0 will be uploaded to dist-git once you import the package, after that it will stay the same in Fedora repos. > I don't know any concrete issue with it, but I felt that adding almost all Requires also into BuildRequires for running the test suite seems weird and I was worried there could be some negative effects to this. It is not weird, it is the correct procedure to test if the package is working as expected. > Yep, they are present (in rawhide). Built python3-fastpurge RPM is installable in latest fedora:rawhide container image. Ha I see, I tried searching for akamai instead of edgegrid and couldn't find the dep. BR should then be: BuildRequires: python3dist(edgegrid-python) BuildRequires: python3dist(more-executors) Tests run fine: + /usr/bin/python3 -m pytest -v ============================= test session starts ============================== platform linux -- Python 3.7.3, pytest-3.9.3, py-1.7.0, pluggy-0.8.1 -- /usr/bin/python3 cachedir: .pytest_cache rootdir: /builddir/build/BUILD/python-fastpurge-1.0.2, inifile: plugins: requests-mock-1.5.2 collecting ... collected 10 items tests/test_auth_dict.py::test_auth_from_dict PASSED [ 10%] tests/test_auth_dict.py::test_auth_bad_type PASSED [ 20%] tests/test_auth_dict.py::test_auth_missing_settings PASSED [ 30%] tests/test_auth_dict.py::test_auth_from_home_edgerc PASSED [ 40%] tests/test_auth_dict.py::test_auth_from_custom_edgerc PASSED [ 50%] tests/test_purge.py::test_purge_by_url PASSED [ 60%] tests/test_purge.py::test_purge_by_tag PASSED [ 70%] tests/test_purge.py::test_scheme_port PASSED [ 80%] tests/test_purge.py::test_response_fails PASSED [ 90%] tests/test_purge.py::test_split_requests PASSED [100%] ========================== 10 passed in 6.60 seconds =========================== + exit 0 I strongly suggest you add them. Maybe you could convince upstream to add them to the Pypi archive for the next release if you prefer. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
