https://bugzilla.redhat.com/show_bug.cgi?id=1694278 --- Comment #2 from Rohan McGovern <rohan@xxxxxxxxxxxxxx> --- > Consider running the tests: > > Source0: %url/archive/v%{version}/%{srcname}-%{version}.tar.gz The tests aren't included in the tarball shipped to PyPI, I guess that may be why you've suggested a Source0 pointing at github there. Should we point Source* at github archive actually? I've released things that way in the past but started to become uncomfortable with it, not knowing whether that's stable and not having control over it. I just did a quick search about this and it seems indeed there *have* been incidents where github archive contents suddenly changed, e.g. https://github.com/spack/spack/issues/5411. So today's Source0 might be unreproducible tomorrow. If we'd want to use %check here, I guess I should rather have the tests included in the upstream releases to PyPI. > BuildRequires: python3dist(akamai.edgegrid) > BuildRequires: python3dist(more_executors) On a related note, is there any more guidance about when %check should be used? https://docs.fedoraproject.org/en-US/packaging-guidelines/#_test_suites is so terse. I don't know any concrete issue with it, but I felt that adding almost all Requires also into BuildRequires for running the test suite seems weird and I was worried there could be some negative effects to this. > You'll need to package python-akamai-edgegrid and python-more_executors, > which you should do anyway otherwise your package can't work. Yep, they are present (in rawhide). Built python3-fastpurge RPM is installable in latest fedora:rawhide container image. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
