https://bugzilla.redhat.com/show_bug.cgi?id=1689634 --- Comment #11 from Jan Staněk <jstanek@xxxxxxxxxx> --- (In reply to Timothée Floure from comment #10) > I wasn't aware of those macros (and did not find them rpm.org!) and could > not find a way to work with non-archived sources with %setup or %autosetup. Yeah, the RPM documentation is sparse and kind of all over the place… In other news: - The `%{?systemd_requires}` fixed directory ownership for the systemd unit (mako.service), but unfortunately not for dbus unit (fr.emersion.Mako.service). Looking at dunst, it may be fixed by adding `Requires: dbus`. In order for the service to actually pick up the notifications, the dbus is required, so I think it makes sense to add it. - Also from reading dunst spec file, it `Provides: desktop-notification-daemon`. I was not able to find anything specific to that provide, but according to `dnf provides desktop-notification-daemon` all the other notification daemons do provide it – so I guess mako should as well. All other issues seems to have been fixed, so hopefully this is the last iteration ;) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
