https://bugzilla.redhat.com/show_bug.cgi?id=1689634 --- Comment #7 from Timothée Floure <timothee.floure@xxxxxxx> --- Spec URL: https://paste.sr.ht/blob/4ac99254f98b254cd510f44d3cc793152dac1a25 SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/3934/33883934/mako-1.2-1.fc31.src.rpm 1. Fixed. 2. Fixed, missed this part of the systemd-related guidelines. 3. Hum, an extra source file implies to build an archive (is there another way?). The patch feels more convenient and seems right to me since I plan to upstream it anyway. > Let me know if I can help you with anything else, as I realise that repeated requested adjustment to your work can be frustrating. Keep up the good work! I can't complain about such a comprehensive review ;-) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
