https://bugzilla.redhat.com/show_bug.cgi?id=1689634 --- Comment #6 from Jan Staněk <jstanek@xxxxxxxxxx> --- Few more adjustments are necessary, unfortunately: 1. wayland-protocols dependency is constrained even in the 1.2 release [1] - BuildRequires: pkgconfig(wayland-protocols) >= 1.14 2. The systemd unit files complicate things a bit. Details in [2] and [3], but in short: - Add `BuildRequires: systemd-rpm-macros` to make the following lines work - Add `%{?systemd_requires}` line which expands to Requires necessary for systemd unit files; this should also fix ownership issues for directories that the unit files are installed into. - Add %preun and %post scriptlets with `%systemd_user_preun %{name}.service` and `%systemd_user_post %{name}.service`, respectivelly. These define (for example) what to do when the service is running and the package is updated/uninstalled. 3. The downstream service/unit files should probably be added as additional Source(s), not as a patch to the original source. That way it is more obvious that the files originate from our (Fedora) side and they are not backports from upstream. Again, once upstream accepts the files for their own and releases an update that contains them, the downstream versions should be dropped. Let me know if I can help you with anything else, as I realise that repeated requested adjustment to your work can be frustrating. Keep up the good work! [1]: https://github.com/emersion/mako/blob/v1.2/meson.build#L26 [2]: https://docs.fedoraproject.org/en-US/packaging-guidelines/Systemd/#_packaging [3]: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
