https://bugzilla.redhat.com/show_bug.cgi?id=1671571 --- Comment #7 from Fabio Valentini <decathorpe@xxxxxxxxx> --- > (In reply to Fabio Valentini from comment #5) > > Just some small comments from a Packaging Committee member: > > > > - Please don't include static libraries, unless *absolutely necessary*. > > In this case, I think it can be safely removed (probably by rm-ing it from > > the buildroot at the end of %install): > > rm %{buildroot}/%{_libdir}/lib%{name}.a > > > > It seems the static library is necessary? My Koji build [5] and COPR build > [6] failed without it. It's not. You just forgot to remove the corresponding entry from the %files section - and now it can't find the file that you removed - that's all. > > - Depending on the size of the html docs, they should be moved to a > > separate, (probably noarch) -doc sub-package. > > > > For example, fedora-review recommends to move documentation to a separate > > sub-package if it's bigger than 1 MB. > > The HTML docs were only 500KB or so, but I went ahead and split them out > into their own package anyways. Nice, thanks! > -- > [1] > https://pagure.io/jflory7-rpm-specs/c/ > 476d05cbafe8913a8d0af4c29bb439a3d1264af5?branch=master > [2] https://koji.fedoraproject.org/koji/taskinfo?taskID=32534256 > [3] https://koji.fedoraproject.org/koji/taskinfo?taskID=32534242 > [4] https://copr.fedorainfracloud.org/coprs/jflory7/playerctl/build/853863/ > [5] https://koji.fedoraproject.org/koji/taskinfo?taskID=32533723 > [6] https://copr.fedorainfracloud.org/coprs/jflory7/playerctl/build/853848/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
