https://bugzilla.redhat.com/show_bug.cgi?id=1636111 --- Comment #7 from mati86dl@xxxxxxxxx --- Hi Mukundan, New source package and Spec: Spec URL: https://services.delellis.com.ar/data/rpmbuild/SPECS/glyr.spec SRPM URL: https://services.delellis.com.ar/data/rpmbuild/SRPMS/glyr-1.0.10-5.20180824git618c418e.fc28.src.rpm > (1) drop BuildRoot definition Done. > (2) Drop all "rm -rd %{buildroot}" lines Done. > (3) Sub-packages should be %{name}-libs and %{name}-devel. Towards that, > > "%package -n lib%{name}" should be "%package -n libs" > > > Similarly, > "%package -n lib%{name}-devel" should be "%package -n devel" Done, but use "%package -n %{name}-devel" instead "%packege -n devel", If not, just generate the "devel*.rpm" package. ;) > Make appropriate changes in the %description lines as well. Done. > (4) Buildrequires on curl should either be curl-devel or pkconfig(curl). This is the only thing that is not fixed. :disapointed: The spec has the dependency to libcurl-devel (See line #27), and according to the libcurl package, this is the correct name. See: https://src.fedoraproject.org/rpms/curl/blob/master/f/curl.spec#_127 > (5) drop %post and %postun Done. > (6) drop the %clean section. Done > (7) drop %defattr lines. Done. Well, I hope your comments. Thank for the review!. ;) Regards, Matias. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
