https://bugzilla.redhat.com/show_bug.cgi?id=1641203 --- Comment #3 from Neal Gompa <ngompa13@xxxxxxxxx> --- Spec review: > %define libname lib%{basen}%{major} %global is preferred over %define Cf. https://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define Also, Fedora does not require that the so major version be included in library package names, so it's okay for it to be "lib%{name}". > Name: %{basen} This appears to be unnecessary, can you just put "Name: freecell-solver" and use "%{name}" where you were using "%{basen}"? > Release: 1 Fedora packages must have the DistTag in the release. See https://fedoraproject.org/wiki/Packaging:DistTag > Group: Games/Cards This is not a valid group for Fedora. And RPM Groups are now optional. Fedora RPM Groups: https://fedoraproject.org/wiki/RPMGroups > Requires: %{name}-data >= %{version}-%{release} This should actually be "= %{version}-%{release}", as these should move in lockstep. > Conflicts: %{_lib}%{name}0 < 4.16.0-3 > Conflicts: %{name} < 4.16.0-3 These should be removed, as they don't apply to Fedora. Also, %{name}-data subpackage should have "BuildArch: noarch". > Requires: %{libname} = %version-%release Please use consistent formatting here, so "%version-%release" should be "%{version}-%{release}". -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
