https://bugzilla.redhat.com/show_bug.cgi?id=1640695 Jakub Jelen <jjelen@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jjelen@xxxxxxxxxx --- Comment #2 from Jakub Jelen <jjelen@xxxxxxxxxx> --- Neal, sorry for stepping in, but I did not see any update from you during last days, so I am submitting my preliminary review since I verbally promised it to Lukas. >From automated fedora-review: Issues: ======= - Package uses either %{buildroot} or $RPM_BUILD_ROOT Note: Using both %{buildroot} and $RPM_BUILD_ROOT See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros - None of the files have any license header. - No known owner of /usr/share/udica/templates - you probably need to specify this directory explicitly in your files section Rpmlint ------- udica.noarch: W: spelling-error %description -l en_US inheritence -> inheritance, inheritor, incoherence udica.noarch: W: spelling-error %description -l en_US mountpoints -> mount points, mount-points, outpoints udica.noarch: E: description-line-too-long C Tool for generating SELinux security profiles for containers. The whole concept is based on "block inheritence" feature inside CIL intermediate language supported by SELinux userspace. The tool creates a policy which combines rules inherited from specified CIL blocks(templates) and rules discovered by inspection of container JSON file, which contains mountpoints and ports definitions. udica.noarch: E: non-executable-script /usr/lib/python3.6/site-packages/udica/parse.py 644 /bin/python3 udica.noarch: E: non-executable-script /usr/lib/python3.6/site-packages/udica/perms.py 644 /bin/python3 udica.noarch: E: non-executable-script /usr/lib/python3.6/site-packages/udica/policy.py 644 /bin/python3 udica.src:21: W: setup-not-quiet udica.src:84: W: macro-in-%changelog %files 2 packages and 0 specfiles checked; 5 errors, 6 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
