https://bugzilla.redhat.com/show_bug.cgi?id=1636111 --- Comment #6 from Mukundan Ragavan <nonamedotc@xxxxxxxxx> --- Some comments about bringing the spec file to Fedora's standards (1) drop BuildRoot definition (2) Drop all "rm -rd %{buildroot}" lines (3) Sub-packages should be %{name}-libs and %{name}-devel. Towards that, "%package -n lib%{name}" should be "%package -n libs" Similarly, "%package -n lib%{name}-devel" should be "%package -n devel" Make appropriate changes in the %description lines as well. (4) Buildrequires on curl should either be curl-devel or pkconfig(curl). (5) drop %post and %postun (6) drop the %clean section. (7) drop %defattr lines. Good start! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
